uranusjr commented on a change in pull request #21442:
URL: https://github.com/apache/airflow/pull/21442#discussion_r803313059
##########
File path: airflow/utils/operator_resources.py
##########
@@ -50,6 +50,8 @@ def __init__(self, name, units_str, qty):
self._qty = qty
def __eq__(self, other):
+ if not isinstance(other, self.__class__):
+ return False
Review comment:
Probably better to use `NotImplemented` instead.
https://docs.python.org/3.6/library/constants.html#NotImplemented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
