potiuk edited a comment on pull request #18853:
URL: https://github.com/apache/airflow/pull/18853#issuecomment-939364036


   > > Why? The dependency-based ordering (topological) does not guarantee to 
match alphabetical ordering. I think we need to > Because this is how test dags 
are constructed. If you process them in the deterministic order, it works. If 
the order is random, it sometimes does not. That's as simple as that. there is 
no "dependency check" here. Unlike the previous attemtpt which sometimes 
worked, sometimes did not - this will work for sure.
   
   The problem (here and few other tests) is that there was an implicit 
assumption that all tasks will have state set. But this is not how it works 
when you process the tasks in test in random order. If you first process the 
tasks that are depending on other (non-processed) tasks, they will keeep their 
state to None - which causes test failure. Fortunately the structure of the 
test tasks is that if you process them in the alphabetical order, the test will 
always succeed - because task1 is before task2 (and in our tests task2 depends 
on task1). 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to