zachliu commented on pull request #18764:
URL: https://github.com/apache/airflow/pull/18764#issuecomment-938704331


   > > one question: should we adjust the default behavior of "full_url_mode" 
to `true`? otherwise this could break existing processes thinking
   > 
   > It is true by default.
   
   oops, i must have mixed
   
https://github.com/apache/airflow/blob/22768ff61e1b8d3294c30562fa2ee284ee0f7739/airflow/providers/amazon/aws/secrets/secrets_manager.py#L114
   
   with the 
[docs](https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-amazon/secrets-backends/aws-secrets-manager.rst).
   
   thanks for clarifying :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to