uranusjr commented on a change in pull request #18819:
URL: https://github.com/apache/airflow/pull/18819#discussion_r724639439
##########
File path: airflow/providers/salesforce/hooks/salesforce.py
##########
@@ -171,9 +171,7 @@ def make_query(
query_params = query_params or {}
query_results = conn.query_all(query, include_deleted=include_deleted,
**query_params)
- self.log.info(
- "Received results: Total size: %s; Done: %s",
query_results['totalSize'], query_results['done']
- )
+ self.log.info("Received results: Total size: {totalSize}; Done:
{done}".format(query_results))
Review comment:
The previous code is correct.
https://blog.pilosus.org/posts/2020/01/24/python-f-strings-in-logging/
The article is about f-strings, but also applies to eager `.format()` calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
