(accumulo) branch 2.1 updated: Added log.isTraceEnabled to LogFileKey (#5499)

[dlmarion]

This is an automated email from the ASF dual-hosted git repository.

dlmarion pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/2.1 by this push:
     new c2df3baeae Added log.isTraceEnabled to LogFileKey (#5499)
c2df3baeae is described below

commit c2df3baeae3af49a917cdadf49c6d83f87269529
Author: Dave Marion <dlmar...@apache.org>
AuthorDate: Wed Apr 23 15:22:16 2025 -0400

    Added log.isTraceEnabled to LogFileKey (#5499)
    
    There are two trace statements that use Arrays.toString()
    as an argument. The methods where these log statements are
    found are used frequently in log recovery and the call
    to Arrays.toString may be unnecessary if trace logging is
    disabled.
---
 .../java/org/apache/accumulo/tserver/logger/LogFileKey.java    | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git 
a/server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogFileKey.java
 
b/server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogFileKey.java
index 18d6c7e321..6f43344b23 100644
--- 
a/server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogFileKey.java
+++ 
b/server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogFileKey.java
@@ -293,7 +293,9 @@ public class LogFileKey implements 
WritableComparable<LogFileKey> {
     row[11] = (byte) ((seq >>> 8) & mask);
     row[12] = (byte) (seq & mask);
 
-    log.trace("Convert {} {} {} to row {}", event, tabletId, seq, 
Arrays.toString(row));
+    if (log.isTraceEnabled()) {
+      log.trace("Convert {} {} {} to row {}", event, tabletId, seq, 
Arrays.toString(row));
+    }
     return row;
   }
 
@@ -347,8 +349,10 @@ public class LogFileKey implements 
WritableComparable<LogFileKey> {
     if (eventType(logFileKey.event) != rowParts[0]) {
       throw new AssertionError("Event in row differs from column family. Key: 
" + key);
     }
-    log.trace("From row {} get {} {} {}", Arrays.toString(rowParts), 
logFileKey.event,
-        logFileKey.tabletId, logFileKey.seq);
+    if (log.isTraceEnabled()) {
+      log.trace("From row {} get {} {} {}", Arrays.toString(rowParts), 
logFileKey.event,
+          logFileKey.tabletId, logFileKey.seq);
+    }
 
     // handle special cases of what is stored in the qualifier
     switch (logFileKey.event) {