This is an automated email from the ASF dual-hosted git repository.
ddanielr pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/2.1 by this push:
new 66ab340696 Clarify property descriptions (#5013)
66ab340696 is described below
commit 66ab340696fa27bd717710d1cca1bcb590545e01
Author: Daniel Roberts <[email protected]>
AuthorDate: Thu Oct 24 23:23:36 2024 +0000
Clarify property descriptions (#5013)
Adds additional words to call out the off-heap nature of the memory.maps
when using native maps.
---
core/src/main/java/org/apache/accumulo/core/conf/Property.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/core/src/main/java/org/apache/accumulo/core/conf/Property.java
b/core/src/main/java/org/apache/accumulo/core/conf/Property.java
index 469aa9fca1..e6d853e40e 100644
--- a/core/src/main/java/org/apache/accumulo/core/conf/Property.java
+++ b/core/src/main/java/org/apache/accumulo/core/conf/Property.java
@@ -617,7 +617,7 @@ public enum Property {
+ " until it is closed.",
"1.3.5"),
TSERV_NATIVEMAP_ENABLED("tserver.memory.maps.native.enabled", "true",
PropertyType.BOOLEAN,
- "An in-memory data store for accumulo implemented in c++ that increases"
+ "An off-heap in-memory data store for accumulo implemented in c++ that
increases"
+ " the amount of data accumulo can hold in memory and avoids Java
GC pauses.",
"1.3.5"),
TSERV_MAXMEM("tserver.memory.maps.max", "33%", PropertyType.MEMORY,
@@ -625,7 +625,8 @@ public enum Property {
+ " tablet server. There are two other properties that can
effectively limit"
+ " memory usage `table.compaction.minor.logs.threshold` and"
+ " `tserver.wal.max.size`. Ensure that
`table.compaction.minor.logs.threshold`"
- + " * `tserver.wal.max.size` >= this property.",
+ + " * `tserver.wal.max.size` >= this property. This map is created
in off-heap"
+ + " memory when " + TSERV_NATIVEMAP_ENABLED.name() + " is enabled.",
"1.3.5"),
TSERV_SESSION_MAXIDLE("tserver.session.idle.max", "1m",
PropertyType.TIMEDURATION,
"When a tablet server's SimpleTimer thread triggers to check idle"