(accumulo) branch 2.1 updated: adds trace logging to CompactionDriver (#4578)

[kturner]

This is an automated email from the ASF dual-hosted git repository.

kturner pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/2.1 by this push:
     new 4426b90418 adds trace logging to CompactionDriver (#4578)
4426b90418 is described below

commit 4426b90418d83121f9c57616f02f894533ac2bca
Author: Keith Turner <ktur...@apache.org>
AuthorDate: Fri May 24 16:08:31 2024 -0400

    adds trace logging to CompactionDriver (#4578)
    
    This logging can be useful to turn on when a compaction does not seem to be 
making progress.
---
 .../manager/tableOps/compact/CompactionDriver.java | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git 
a/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java
 
b/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java
index b17ce8b63c..d3c4b1afc4 100644
--- 
a/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java
+++ 
b/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java
@@ -31,6 +31,8 @@ import 
org.apache.accumulo.core.clientImpl.thrift.TableOperationExceptionType;
 import org.apache.accumulo.core.data.InstanceId;
 import org.apache.accumulo.core.data.NamespaceId;
 import org.apache.accumulo.core.data.TableId;
+import org.apache.accumulo.core.dataImpl.KeyExtent;
+import org.apache.accumulo.core.fate.FateTxId;
 import org.apache.accumulo.core.fate.Repo;
 import org.apache.accumulo.core.fate.zookeeper.ZooReaderWriter;
 import org.apache.accumulo.core.manager.state.tables.TableState;
@@ -44,7 +46,9 @@ import org.apache.accumulo.manager.tableOps.ManagerRepo;
 import org.apache.accumulo.manager.tableOps.Utils;
 import org.apache.accumulo.manager.tableOps.delete.PreDeleteTable;
 import org.apache.accumulo.server.manager.LiveTServerSet.TServerConnection;
+import org.apache.hadoop.io.Text;
 import org.apache.thrift.TException;
+import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 class CompactionDriver extends ManagerRepo {
@@ -62,6 +66,8 @@ class CompactionDriver extends ManagerRepo {
   private byte[] startRow;
   private byte[] endRow;
 
+  private static final Logger log = 
LoggerFactory.getLogger(CompactionDriver.class);
+
   public CompactionDriver(long compactId, NamespaceId namespaceId, TableId 
tableId, byte[] startRow,
       byte[] endRow) {
     this.compactId = compactId;
@@ -133,6 +139,14 @@ class CompactionDriver extends ManagerRepo {
     }
 
     if (tabletsToWaitFor == 0) {
+      if (log.isTraceEnabled()) {
+        KeyExtent extent = new KeyExtent(tableId, endRow == null ? null : new 
Text(endRow),
+            startRow == null ? null : new Text(startRow));
+        log.trace(
+            "{} tablets compacted:{}/{} servers contacted:{} expected id:{} 
compaction extent:{} sleepTime:{}",
+            FateTxId.formatTid(tid), tabletCount - tabletsToWaitFor, 
tabletCount,
+            serversToFlush.size(), compactId, extent, 0);
+      }
       return 0;
     }
 
@@ -158,6 +172,15 @@ class CompactionDriver extends ManagerRepo {
 
     sleepTime = Math.min(sleepTime, 30000);
 
+    if (log.isTraceEnabled()) {
+      KeyExtent extent = new KeyExtent(tableId, endRow == null ? null : new 
Text(endRow),
+          startRow == null ? null : new Text(startRow));
+      log.trace(
+          "{} tablets compacted:{}/{} servers contacted:{} expected id:{} 
compaction extent:{} sleepTime:{}",
+          FateTxId.formatTid(tid), tabletCount - tabletsToWaitFor, tabletCount,
+          serversToFlush.size(), compactId, extent, sleepTime);
+    }
+
     return sleepTime;
   }