On 10 Jan 2009, at 00:40, Kyle Sluder wrote:

On Fri, Jan 9, 2009 at 7:11 PM, Adam Foltzer <acfolt...@gmail.com> wrote:
- (id)initWithInt:(int)foo
{
  if (![super init])
      return nil;
  [self setFoo:foo];
  return self;
}

Do not use getters and setters in -init.  You should be accessing the
ivars directly.

While we're on this topic, I think a more important problem with the above is the assumption that [super init] either returns nil or the current value of self.

It should of course be

  if ((self = [super init])) {
    // Initialise
  }
  return self;

or some equivalent construct.

Kind regards,

Alastair.

--
http://alastairs-place.net



_______________________________________________

Cocoa-dev mailing list (Cocoa-dev@lists.apple.com)

Please do not post admin requests or moderator comments to the list.
Contact the moderators at cocoa-dev-admins(at)lists.apple.com

Help/Unsubscribe/Update your Subscription:
http://lists.apple.com/mailman/options/cocoa-dev/archive%40mail-archive.com

This email sent to arch...@mail-archive.com

Reply via email to