----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9923/#review18124 -----------------------------------------------------------
Commit af0723e9c9259619c2cb5d77396e2297f1273a5e in branch refs/heads/4.0 from Chip Childers <chip.child...@gmail.com> [ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=af0723e ] CLOUDSTACK-1668: Fix IP conflict in VPC tier Currently, allPossibleIps return the Ip lists which include the gateway, so we need to remove gateway ip from this list. Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists which do not include the first IP of the network (like 192.168.0.1). We need too add the first IP into the returned Ip list, because it can be used for VM if it is not the gateway IP (for example, VPC networks). Signed-off-by: Chip Childers <chip.child...@gmail.com> - ASF Subversion and Git Services On March 14, 2013, 8:41 p.m., Wei Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9923/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 8:41 p.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Description > ------- > > Currently, allPossibleIps return the Ip lists which include the gateway, so > we need to remove gateway ip from this list. > > Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return > the Ip lists which do not include the first IP of the network (like > 192.168.0.1). > We need too add the first IP into the returned Ip list, because it can be > used for VM if it is not the gateway IP (for example, VPC networks). > > > This addresses bug CLOUDSTACK-1668. > > > Diffs > ----- > > server/src/com/cloud/network/NetworkManagerImpl.java b33c52b > utils/src/com/cloud/utils/net/NetUtils.java 1341338 > > Diff: https://reviews.apache.org/r/9923/diff/ > > > Testing > ------- > > Testing manually ok in VPC tier and non-VPC network. > > > Thanks, > > Wei Zhou > >
