----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9696/#review17961 -----------------------------------------------------------
Can you please also tell me a list of tests done for this ? server/src/com/cloud/configuration/Config.java <https://reviews.apache.org/r/9696/#comment37964> are there any dependencies on this flag in the code ? We need to remove this flag during migration as well. server/src/com/cloud/storage/download/DownloadMonitorImpl.java <https://reviews.apache.org/r/9696/#comment37962> can you please use SecondaryStorageVmManager instead ? server/src/com/cloud/storage/upload/UploadMonitorImpl.java <https://reviews.apache.org/r/9696/#comment37963> can you put an example here...seems some hardcoding - Nitin Mehta On March 6, 2013, 10:06 a.m., Wei Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9696/ > ----------------------------------------------------------- > > (Updated March 6, 2013, 10:06 a.m.) > > > Review request for cloudstack, Nitin Mehta and Jayapal Reddy. > > > Description > ------- > > This patch is for issue CLOUD-1475 (RegisterISO error after Update SSL > Certificate) > on CloudStack 4.0.1. > > > Changes include: > (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh) > (2) change suffix of download iso/template url rom realhostip.com to > domain_suffix in SSL Certificate. > (3) validate download URL because ssvm publicip or domain suffix may change. > > > This addresses bug CLOUD-1475. > > > Diffs > ----- > > agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java > 48f5079 > console-proxy/scripts/config_ssl.sh 8d80c47 > core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java > c606fca > core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java > 155210d > server/src/com/cloud/configuration/Config.java dbcc97a > server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java > 01b4720 > > server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java > 6172780 > server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c > server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b > server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 > server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 > > Diff: https://reviews.apache.org/r/9696/diff/ > > > Testing > ------- > > Testing manually ok. > > We need to restart management-server after Update SSL Certificate > > > Thanks, > > Wei Zhou > >
