----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9772/#review17815 -----------------------------------------------------------
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java <https://reviews.apache.org/r/9772/#comment37778> Patch is not applying cleanly on latest master. git am 0001-fix-bug-vmware-create-volume-from-snapshot-will-miss.patch Applying: fix bug vmware create volume from snapshot will missing data error: patch failed: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java:665 error: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java: patch does not apply Patch failed at 0001 fix bug vmware create volume from snapshot will missing data When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java <https://reviews.apache.org/r/9772/#comment37777> Need whitespacing around operator '+' - Sateesh Chodapuneedi On March 8, 2013, 11:35 a.m., Hongtu Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9772/ > ----------------------------------------------------------- > > (Updated March 8, 2013, 11:35 a.m.) > > > Review request for cloudstack, Sateesh Chodapuneedi, mice xia, and Kelven > Yang. > > > Description > ------- > > fix bug CLOUDSTACK-1531: vmware create volume from snapshot will missing data > The code works in ssvm > > > This addresses bug CLOUDSTACK-1531. > > > Diffs > ----- > > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java > 8650274 > > Diff: https://reviews.apache.org/r/9772/diff/ > > > Testing > ------- > > 1. deploy a centos vm > 2. create a volume v0 and attached to the vm > 3. before formatting v0, take a snapshot s1, then format it and touch some > files > 4. take another snapshot s2, and detach v0 > 5. create volume v1 from s1 and then create volume v2 from s2 > > Success. v1 and v2 has different data. v1 doesn't contains partition and v2 > has files I touched. > > > Thanks, > > Hongtu Zang > >
