We need to verify that upgrades are addressed too On Mar 12, 2013 6:43 PM, "Chip Childers" <chip.child...@sungard.com> wrote:
> On Tue, Mar 12, 2013 at 06:39:09PM -0600, Marcus Sorensen wrote: > > This addresses CLOUDSTACK-600. Please get buyoff from Wido if > > possible, since it's his patch. I've reviewed and tested it, but I > > want to make sure I'm not wrong in assuming that this should be in 4.1 > > > > commit 5dfcd309f10e5bd6a918f7fdff3f44a3dff2374a > > Author: Wido den Hollander <w...@widodh.nl> > > Date: Thu Feb 7 22:58:20 2013 +0100 > > > > agent: Do not define domains persistent in libvirt > > > > We used to define domains persistent in libvirt, which caused XML > > definitions > > to stay there after a reboot of the hypervisor. > > > > We however don't do anything with those already defined domains, > > actually, we wipe > > all defined domains when starting the agent. > > > > Some users however reported that libvirt started these domains > > after a reboot > > before the CloudStack agent was started. > > > > By starting domains from the XML description and not defining them > > we prevent > > them from ever being stored in libvirt. > > > > Wido - I'll let you comment before we apply this. >