Hmm - I see client/WEB-INF has the web.xml which isn't generated. The
mvn rat check doesn't pass on the dev environment because of many of
the .txt files within awsapi/. These aren't part of the repo but are
generated during the build. So it's hard to tell whether the license
check passed or not from my dev environment.

How about restricting the regex to do only WEB-INF that is generated?
The one I applied is too wide.


On Thu, Mar 07, 2013 at 06:11:47PM +0530, David Nalley wrote:
> There is also a number of non-generated files in WEB-INF
> directories... can you explain this a bit more?
> 
> --David
> 
> On Thu, Mar 7, 2013 at 4:06 AM,  <t...@apache.org> wrote:
> > Updated Branches:
> >   refs/heads/master 7fde29888 -> 81a42b959
> >
> >
> > rat check: exclude the WEB-INF directories in check
> >
> > WEB-INF directories will carry generated code so exclude them.
> >
> > Signed-off-by: Prasanna Santhanam <t...@apache.org>
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
> > Commit: 
> > http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/81a42b95
> > Tree: 
> > http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/81a42b95
> > Diff: 
> > http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/81a42b95
> >
> > Branch: refs/heads/master
> > Commit: 81a42b95917f94a82bd0b45bff1fcb0d79111d5b
> > Parents: 7fde298
> > Author: Prasanna Santhanam <t...@apache.org>
> > Authored: Thu Mar 7 14:20:06 2013 +0530
> > Committer: Prasanna Santhanam <t...@apache.org>
> > Committed: Thu Mar 7 14:35:53 2013 +0530
> >
> > ----------------------------------------------------------------------
> >  pom.xml |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> > http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/81a42b95/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/pom.xml b/pom.xml
> > index c10297a..9b72fb7 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -346,6 +346,7 @@
> >                <exclude>**/.classpath</exclude>
> >                <exclude>**/.project</exclude>
> >                <exclude>**/*.iml</exclude>
> > +              <exclude>**/WEB-INF/**</exclude>
> >                <exclude>**/.settings/**</exclude>
> >                <exclude>.metadata/**</exclude>
> >                <exclude>.git/**</exclude>
> >

-- 
Prasanna.,

Reply via email to