----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9753/#review17480 -----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/admin/resource/ArchiveAlertsCmd.java <https://reviews.apache.org/r/9753/#comment37089> If you are internally using uuids for these Ids passed in, you may not be able to handle some upgraded cases, where there is no UUIDs for those old Alerts/Events customers have created before we introduced UUID. Generally we internally use Long db id for these cases in our command, will convert over-the-wire UUID to internal ID based on annotation. Please confirm with Rohit about recommended way for this list of Id cases. api/src/org/apache/cloudstack/api/command/admin/resource/ArchiveAlertsCmd.java <https://reviews.apache.org/r/9753/#comment37070> Description should be "delete alert..." client/tomcatconf/commands.properties.in <https://reviews.apache.org/r/9753/#comment37072> Based on FS, only root admin can archive or delete alerts, so we should have archiveAlerts = 1 deleteAlerts = 1 core/src/com/cloud/event/dao/EventDaoImpl.java <https://reviews.apache.org/r/9753/#comment37073> If this is used to search events older than certain date, should this be Op.LT instead of Op.GTEQ? server/src/com/cloud/alert/dao/AlertDaoImpl.java <https://reviews.apache.org/r/9753/#comment37074> Similar to above comment for event, should this be Op.LT if we want to search for alerts older than given date? server/src/com/cloud/api/query/QueryManagerImpl.java <https://reviews.apache.org/r/9753/#comment37075> So with archive feature, previous listAlerts or listEvents will not show archived alerts or events anymore, right? - Min Chen On March 6, 2013, 6:16 p.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9753/ > ----------------------------------------------------------- > > (Updated March 6, 2013, 6:16 p.m.) > > > Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min > Chen. > > > Description > ------- > > This feature will provide the functionality to delete or archive > the Alerts/Events. > Delete or archive alerts APIs are available only for root-admin, > delete or archive events are available for regular users. > > Functional > Spec:https://cwiki.apache.org/confluence/display/CLOUDSTACK/Ability+to+delete+or+archive+Events+and+Alerts > > > This addresses bugs Ability, Alerts, CLOUDSTACK-874, Events, and, delete, and > to. > > > Diffs > ----- > > api/src/com/cloud/alert/Alert.java 050f97f > api/src/com/cloud/event/Event.java 1a61636 > api/src/com/cloud/server/ManagementService.java 1736da3 > api/src/org/apache/cloudstack/api/ApiConstants.java 1b544fd > > api/src/org/apache/cloudstack/api/command/admin/resource/ArchiveAlertsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/resource/DeleteAlertsCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/user/event/ArchiveEventsCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java > PRE-CREATION > client/tomcatconf/commands.properties.in dd0c3f8 > core/src/com/cloud/alert/AlertVO.java f6089d6 > core/src/com/cloud/event/EventVO.java ac46f24 > core/src/com/cloud/event/dao/EventDao.java bfcb818 > core/src/com/cloud/event/dao/EventDaoImpl.java 44fbb03 > server/src/com/cloud/alert/dao/AlertDao.java eb1faa5 > server/src/com/cloud/alert/dao/AlertDaoImpl.java 2f3be88 > server/src/com/cloud/api/ApiDispatcher.java 764b3ae > server/src/com/cloud/api/query/QueryManagerImpl.java 8d8663a > server/src/com/cloud/api/query/vo/EventJoinVO.java f29a942 > server/src/com/cloud/configuration/Config.java 418f97d > server/src/com/cloud/server/ManagementServerImpl.java 3c615e1 > server/test/com/cloud/alert/AlertControlsUnitTest.java PRE-CREATION > server/test/com/cloud/event/EventControlsUnitTest.java PRE-CREATION > setup/db/db/schema-410to420.sql f3112a1 > > Diff: https://reviews.apache.org/r/9753/diff/ > > > Testing > ------- > > Tested the new API archiveAlerts, deleteAlerts, archiveEvents, deleteEvents > with all the possible combinations of parameters as input on my local > CloudStack setup. > > > Thanks, > > Sanjay Tripathi > >
