Ok thanks for following up Animesh
> -----Original Message----- > From: Nitin Mehta > Sent: Tuesday, March 05, 2013 12:00 AM > To: Animesh Chaturvedi; cloudstack-dev@incubator.apache.org; Saksham > Srivastava; Devdeep Singh; Abhinandan Prateek > Subject: Re: Review Request: CLOUDSTACK-924: source_template_id set to > NULL when a template is created from a snapshot > > Hi Animesh, > Saksham is supposed to send a rebased request to me. Below is what he > wrote to me. > > > > The code has changed a lot after the storage refactoring. > I will submit a new patch after resolving the conflicts. > > Saksham > > > On Thursday 28 February 2013 12:03 PM, Nitin Mehta wrote: > >Nitins-MacBook-Air:incubator-cloudstack nitinmehta$ git apply > >--whitespace=fix ../pppp.patch > >error: patch failed: > >server/src/com/cloud/storage/StorageManagerImpl.java:477 > >error: server/src/com/cloud/storage/StorageManagerImpl.java: patch does > >not apply Nitins-MacBook-Air:incubator-cloudstack nitinmehta$ > > > > > > On 01/03/13 3:57 AM, "Animesh Chaturvedi" > <animesh.chaturv...@citrix.com> > wrote: > > >Nitin > > > >This has been pending your review since couple of days. Please attend > >to this review and close it > > > >Animesh > > > >> -----Original Message----- > >> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] > >> Sent: Wednesday, February 13, 2013 7:34 PM > >> To: Saksham Srivastava; Nitin Mehta; Devdeep Singh > >> Cc: cloudstack > >> Subject: RE: Review Request: CLOUDSTACK-924: source_template_id set > >> to NULL when a template is created from a snapshot > >> > >> Nitin > >> > >> Please review the updates patch and commit if satisfied > >> > >> > -----Original Message----- > >> > From: Saksham Srivastava [mailto:nore...@reviews.apache.org] On > >> > Behalf Of Saksham Srivastava > >> > Sent: Monday, February 11, 2013 3:38 AM > >> > To: Nitin Mehta; Devdeep Singh > >> > Cc: Saksham Srivastava; cloudstack > >> > Subject: Re: Review Request: CLOUDSTACK-924: source_template_id > set > >> > to NULL when a template is created from a snapshot > >> > > >> > > >> > ----------------------------------------------------------- > >> > This is an automatically generated e-mail. To reply, visit: > >> > https://reviews.apache.org/r/8900/ > >> > ----------------------------------------------------------- > >> > > >> > (Updated Feb. 11, 2013, 11:37 a.m.) > >> > > >> > > >> > Review request for cloudstack, Devdeep Singh and Nitin Mehta. > >> > > >> > > >> > Description > >> > ------- > >> > > >> > Volumes created from snapshots misses the source template > >> > information.Fixed the issue with volumes now getting the template id. > >> > > >> > > >> > This addresses bug CLOUDSTACK-924. > >> > > >> > > >> > Diffs > >> > ----- > >> > > >> > server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe > >> > > >> > Diff: https://reviews.apache.org/r/8900/diff/ > >> > > >> > > >> > Testing > >> > ------- > >> > > >> > Verified on local setup. from > >> > template1->instance->snapshot1->volume1- > >> > >snapshot2->template2 > >> > template2 now has source template id. > >> > > >> > > >> > Thanks, > >> > > >> > Saksham Srivastava > >
