----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9736/#review17365 -----------------------------------------------------------
Ship it! Committed to 4.1: commit 02bbb10826a22cb3f1bcebfdc1c98b174b1371c0 Author: Min Chen <min.c...@citrix.com> Date: Mon Mar 4 13:43:49 2013 -0800 CLOUDSTACK-1449: listAccounts and listProjectAccounts API lists all the users not account-specific users for each account returned. - Chip Childers On March 4, 2013, 9:48 p.m., Min Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9736/ > ----------------------------------------------------------- > > (Updated March 4, 2013, 9:48 p.m.) > > > Review request for cloudstack and Chip Childers. > > > Description > ------- > > In UserAccountJoinDaoImpl.searchForAccountId(accountid), we used mismatched > condition name "accountId" (vs. "accountid") to specify account condition, > which caused returning all users for an account. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1449. > > > Diffs > ----- > > server/src/com/cloud/api/query/dao/UserAccountJoinDaoImpl.java 1bb3981 > > Diff: https://reviews.apache.org/r/9736/diff/ > > > Testing > ------- > > Verified that the bug is fixed. > > > Thanks, > > Min Chen > >