Even with Nitin's revert, master still failed with the following error:
Exception in thread "main" java.lang.NumberFormatException: For input
string: ""
at
java.lang.NumberFormatException.forInputString(NumberFormatException.java:4
8)
at java.lang.Integer.parseInt(Integer.java:470)
at java.lang.Short.parseShort(Short.java:120)
at java.lang.Short.parseShort(Short.java:78)
at com.cloud.api.doc.ApiXmlDocWriter.main(ApiXmlDocWriter.java:147)
[ERROR] Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (compile) on project
cloud-apidoc: Command execution failed. Process exited with an error: 1
(Exit value: 1) -> [Help 1]
Anybody knows about this?
Thanks
-min
On 3/4/13 10:00 AM, "Alex Huang" <[email protected]> wrote:
>-1 on this checkin
>
>And this is not a small change. 18 files. Some large completely new
>methods checked in. Changes to the virtual machine state machine. No
>unit testing.
>
>I would reject this fix on these problems alone.
>
>--Alex
>
>> -----Original Message-----
>> From: Alex Huang [mailto:[email protected]]
>> Sent: Monday, March 4, 2013 9:56 AM
>> To: [email protected]
>> Cc: Nitin Mehta; Abhinandan Prateek
>> Subject: RE: Master branch build is broken again
>>
>> Min,
>>
>> You should just revert the commit.
>>
>> --Alex
>>
>> > -----Original Message-----
>> > From: Min Chen [mailto:[email protected]]
>> > Sent: Monday, March 4, 2013 9:51 AM
>> > To: [email protected]
>> > Cc: Nitin Mehta
>> > Subject: Master branch build is broken again
>> > Importance: High
>> >
>> > Hi there,
>> >
>> > I could not compile master after pulling latest code today, build
>> > failed with the following error:
>> >
>> > [ERROR] Failed to execute goal
>> > org.apache.maven.plugins:maven-compiler-
>> > plugin:2.5.1:compile (default-compile) on project cloud-engine-
>> orchestration:
>> > Compilation failure [ERROR] /Users/minc/dev/cloud-
>> > asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity
>> > /a
>> > pi/db/VMEntityVO.java:[52,7]
>> > org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not
>> > abstract and does not override abstract method getNewSvcOfferingId()
>> > in com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
>> >
>> > I checked the commit history, it seems related to commit
>> > e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can
>> > somebody quickly fix this? This is blocking me from verifying
>> > CLOUDSTACK-
>> > 1491 and merge my feature branch vim51_win8.
>> >
>> > Thanks
>> > -min
>> >
>