Hi,

I have reviewed the test cases and looks good.

Since UI has been removed from this feature now, We have to make change 
in the test cases accordingly. Now the UI part will be done through 
log4j-cloud.xml file. For that we have to modify following portion in 
log4j-cloud.xml
    <appender name="SNMP" 
class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
       <param name="Threshold" value="WARN"/>
       <param name="SnmpManagerIpAddresses" value=""/>
       <param name="SnmpManagerPorts" value=""/>
       <param name="SnmpManagerCommunities" value=""/>
       <layout 
class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
          <param name="PairDelimeter" value="//"/>
          <param name="KeyValueDelimeter" value="::"/>
       </layout>
    </appender>

To specify multiple  SnmpManagerIpAddresses one has to give as follows 
with each SNMP Manager separated by ,

    <appender name="SNMP" 
class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
       <param name="Threshold" value="WARN"/>
       <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
       <param name="SnmpManagerPorts" value="162,162"/>
       <param name="SnmpManagerCommunities" value="public,public"/>
       <layout 
class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
          <param name="PairDelimeter" value="//"/>
          <param name="KeyValueDelimeter" value="::"/>
       </layout>
    </appender>.

Alerts can be generated in multiple ways, so take care to cover all the 
scenarios. For example ALERT_TYPE_HOST can be generated in some of the 
following ways
1)   Add host failed due to ModifyStoragePoolCommand failed
2)   Host Disconnected due to Agent problem on host
3)   Incorrect network setup on agent

Thanks,
Anshul

On 01/02/13 15:02, Abhinav Roy wrote:
> Hi,
>
> I've uploaded test cases for feature:  "SNMP Alerts support in CloudStack " 
> and is open for review. Please find the test cases here: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/SNMP+Alerts+Support+in+CloudStack
>
>
>
> Reference FS:  
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+for+Integrating+CS+alerts+via+SNMP+to+external+management+system
>
>
>
> Thanks and regards,
>
> Abhinav
>

Reply via email to