Yes that makes sense. Rayees can you update the patch with comment from Sateesh
> -----Original Message----- > From: Sateesh Chodapuneedi [mailto:nore...@reviews.apache.org] On > Behalf Of Sateesh Chodapuneedi > Sent: Wednesday, February 13, 2013 10:18 PM > To: Sateesh Chodapuneedi; Vijayendra Bhamidipati; Rohit Yadav > Cc: cloudstack; Rayees Namathponnan > Subject: Re: Review Request: Failed to Prepare Secondary Storage in > VMware - CLOUDSTACK-1262 > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9435/#review16563 > ----------------------------------------------------------- > > > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/ > VmwareManagerImpl.java > <https://reviews.apache.org/r/9435/#comment35141> > > How about reading the location from paths.script in > environment.properties file? > I think in that way whenever packaging changes the path need not be > modified in manager's source code. > > > - Sateesh Chodapuneedi > > > On Feb. 13, 2013, 9:21 p.m., Rayees Namathponnan wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/9435/ > > ----------------------------------------------------------- > > > > (Updated Feb. 13, 2013, 9:21 p.m.) > > > > > > Review request for cloudstack, Venkata Siva Vijayendra Bhamidipati, > Sateesh Chodapuneedi, and Rohit Yadav. > > > > > > Description > > ------- > > > > This patch for defect https://issues.apache.org/jira/browse/CLOUDSTACK- > 1262, in latest builds failed to prepare secondary storage VM in VMware, > since we are expecting systemvm.iso is available at > /usr/lib64/cloud/common//vms/systemvm.iso instead of > /usr/share/cloudstack-common/vms/systemvm.iso > > > > Branch 4.1 > > > > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK- > 1262. > > > > > > Diffs > > ----- > > > > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/ > VmwareManagerImpl.java 88e03f5 > > > > Diff: https://reviews.apache.org/r/9435/diff/ > > > > > > Testing > > ------- > > > > Tested with VMware (Branch 4.1) > > > > > > Thanks, > > > > Rayees Namathponnan > > > >
