[ https://issues.apache.org/jira/browse/CLOUDSTACK-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588487#comment-13588487 ]
ASF subversion and git services commented on CLOUDSTACK-1410: ------------------------------------------------------------- Commit 23e232f5faea5683ee72ce8d4a8a286870b9bdb9 in branch refs/heads/ui-regions from [~widodh] [ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=23e232f ] CLOUDSTACK-1410: Add the old constructor to VirtualMachineTO Although the code compiled just fine, add back the old constructor for safety. > Overcommit feature breaks compatibility between 4.0/4.1 management server and > 4.2 agent > --------------------------------------------------------------------------------------- > > Key: CLOUDSTACK-1410 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1410 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Management Server > Affects Versions: 4.1.0, 4.2.0 > Environment: Ubuntu 12.04. 4.0 management server, 4.2 agent > Reporter: Wido den Hollander > Assignee: Bharat Kumar > Fix For: 4.2.0 > > > I just updated one of my agents to the 4.2 (master) code and it failed to > start the new instance. > I got a NullPointerException on this piece of code in > LibvirtComputingResource: > ctd.setShares(vmTO.getCpus() * vmTO.getMinSpeed()); > getMinSpeed() is new, this used to be getSpeed() > The VirtualMachineTO was however changed and getSpeed() was removed. > A 4.0/4.1 management server however sends only the "speed" value instead of > "minSpeed" and "maxSpeed". > This leads to a 4.2 agent not working with 4.0 or 4.1 code. > A couple of suggestions: > - Add getSpeed() (and int speed) back to VirtualMachineTO > - Check if getMinSpeed is empty and fall back to getSpeed if it's NULL > Would that be a acceptable solution? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira