> On Feb. 26, 2013, 8:14 a.m., David Nalley wrote: > > setup/db/db/schema-40to410.sql, line 316 > > <https://reviews.apache.org/r/9541/diff/1/?file=260618#file260618line316> > > > > Why are you making changes to 40to410.sql?
limit CPU and Memory resources feature got shifted to 4.2 because it missed the code-freeze deadline but the patch was up in the review board and Min committed it into the master branch. So moving "Limit CPU and Memory resources" feature related changes from schema-40to410.sql to schema-410-420.sql - Sanjay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9541/#review17080 ----------------------------------------------------------- On Feb. 26, 2013, 7:47 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9541/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2013, 7:47 a.m.) > > > Review request for cloudstack, Devdeep Singh, mice xia, and Min Chen. > > > Description > ------- > > CLOUDSTACK-1156: Limit Primary and Secondary storage for domain/accounts > > Addition of two new resource types i.e. Primary and Secondary storage > space in the existing pool of > resource types. > Added methods to set the limits on these resources using > updateResourceLimit > API command and to get a count using updateResourceCount. Also added > calls in the > Templates, Volumes, Snapshots life cycle to check these limits and to > increment/decrement the new > resource types > > Resource Name :: Resource type number > Primary Storage 10 > Secondary Storage 11 > > Also added jUnit Tests for the same. > > > This addresses bug CLOUDSTACK-1156. > > > Diffs > ----- > > api/src/com/cloud/configuration/Resource.java 7614c8a > api/src/com/cloud/storage/VolumeApiService.java 8517988 > > api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceCountCmd.java > f6d3a98 > > api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLimitCmd.java > 0039f62 > api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java > 955727a > api/src/org/apache/cloudstack/api/response/AccountResponse.java 9a98a35 > api/src/org/apache/cloudstack/api/response/ResourceCountResponse.java > a7fbbf2 > api/src/org/apache/cloudstack/api/response/ResourceLimitResponse.java > b444e7a > server/src/com/cloud/api/ApiResponseHelper.java eafee8a > server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java 898bafc > server/src/com/cloud/api/query/vo/AccountJoinVO.java cd7231c > server/src/com/cloud/baremetal/BareMetalTemplateAdapter.java 0cf19fb > server/src/com/cloud/configuration/Config.java eb6fb24 > server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java 7ff06af > server/src/com/cloud/storage/VolumeManager.java af3cbbf > server/src/com/cloud/storage/VolumeManagerImpl.java a69607f > server/src/com/cloud/storage/dao/SnapshotDao.java 0e378a7 > server/src/com/cloud/storage/dao/SnapshotDaoImpl.java 5b3f273 > server/src/com/cloud/storage/dao/VolumeDao.java d7a2667 > server/src/com/cloud/storage/dao/VolumeDaoImpl.java ca3b82a > server/src/com/cloud/storage/download/DownloadMonitorImpl.java 0bc89e3 > server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ed48bd1 > server/src/com/cloud/template/HyervisorTemplateAdapter.java ad41af5 > server/src/com/cloud/template/TemplateManagerImpl.java 29659d3 > server/src/com/cloud/vm/UserVmManagerImpl.java c2bba63 > server/test/com/cloud/resourcelimit/ResourceLimitManagerImplTest.java > d311ad3 > server/test/com/cloud/vpc/MockResourceLimitManagerImpl.java b9fc861 > setup/db/db/schema-40to410.sql 59b2a7d > setup/db/db/schema-410to420.sql 6c831f0 > utils/src/com/cloud/utils/UriUtils.java a8b5ccb > > Diff: https://reviews.apache.org/r/9541/diff/ > > > Testing > ------- > > Tested life cycle of templates, volumes, snapshots, vm on my local CloudStack > setup. > > > Thanks, > > Sanjay Tripathi > >
