----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9585/#review17077 -----------------------------------------------------------
Ship it! LGTM, 69370c181f17df97c7bb14eec162ba83df141cf6 (4.1) f323c641fdabd8f3fc3500b6588fa0588afeef2e (master) - Prasanna Santhanam On Feb. 25, 2013, 1:11 p.m., Ricardo Katz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9585/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 1:11 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > Message on cloud.spec points to the wrong location for vhd-utils. As this > doesn't stop the cloudstack correct running, this can cause to the end-user > some mistake while installing the software and putting vhd-util on the wrong > place > > > Diffs > ----- > > packaging/centos63/cloud.spec 72022d6 > > Diff: https://reviews.apache.org/r/9585/diff/ > > > Testing > ------- > > I've ran the rpmbuild on cloud.spec and generated RPMs for CentOS 6.3. While > installing the RPM it printed a message about missing vhd-utils. > > After searching the correct location of vhd-utils, I've detected that the > current location changed to new defaults, using the cloudstack-common besides > the cloudstack/management location. > > Changed on cloud.spec, generated new RPMs, installed and the installer now is > searching for vhd-utils in the correct location > > > Thanks, > > Ricardo Katz > >