----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9156/#review16738 -----------------------------------------------------------
Any unit tests or automated functional tests to go along with these changes? - David Nalley On Feb. 18, 2013, 4:10 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9156/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2013, 4:10 p.m.) > > > Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin > Mehta. > > > Description > ------- > > This patch enables cpu and ram overcommit on a per cluster basis(only for > xenserver.). > The dashboard will show actual values instead of the overcommit values. > > > This addresses bug CLOUDSTACK-711. > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/VirtualMachineTO.java 8f3f0eb > api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443 > api/src/org/apache/cloudstack/api/ApiConstants.java d29408e > api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java > 912c396 > api/src/org/apache/cloudstack/api/response/ClusterResponse.java 551e530 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 552afb1 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java > acfd9cf > > plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java > 60e1a61 > > plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java > 721e5f7 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > 88e03f5 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 841a535 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > c7ff5c7 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java > 0ce91bc > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java > 58b8a03 > server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java > a25e401 > server/src/com/cloud/api/ApiDBUtils.java 83132c6 > server/src/com/cloud/api/ApiResponseHelper.java 8c97615 > server/src/com/cloud/capacity/CapacityManager.java fffb41f > server/src/com/cloud/capacity/CapacityManagerImpl.java d7b7053 > server/src/com/cloud/capacity/ComputeCapacityListener.java 8ea695a > server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b > server/src/com/cloud/capacity/dao/CapacityDaoImpl.java baaf391 > server/src/com/cloud/deploy/BareMetalPlanner.java 829a466 > server/src/com/cloud/deploy/FirstFitPlanner.java 66a24ac > server/src/com/cloud/hypervisor/HypervisorGuruBase.java e158962 > server/src/com/cloud/resource/ResourceManagerImpl.java 82013d4 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1838ed2 > server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0 > vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2 > > Diff: https://reviews.apache.org/r/9156/diff/ > > > Testing > ------- > > Did manual testing. > > > Thanks, > > bharat kumar > >
