----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9443/ -----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam. Summary (updated) ----------------- ignor unassignIPFromVpcNetwork in finally block of EnableStaticNat Description (updated) ------- This patch only applies on 4.0, not on master(!) unassignIPFromVpcNetwork processing should not execute when EnableStaticNat succeed. Without this patch, unassignIPFromVpcNetwork will execute whenever EnableStaticNat is successful or failed. This is because of the inconsistent of patch of CLOUDSACK-1211 (https://reviews.apache.org/r/9384/ ). In master, it is ok. https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commitdiff;h=2e2ee2f;hp=8234dfa544625cd300559a7380fee7e9828870f8 In 4.0, it is different. https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commitdiff;h=a61a2b1;hp=19d5f39c579676e59f4b83eb5da3eddef230ff97 Diffs (updated) ----- server/src/com/cloud/network/rules/RulesManagerImpl.java 6c1e27a Diff: https://reviews.apache.org/r/9443/diff/ Testing (updated) ------- Testing OK. Thanks, Wei Zhou
