Murali

Please review the patch and commit if satisfied

Animesh

> -----Original Message-----
> From: Likitha Shetty [mailto:nore...@reviews.apache.org] On Behalf Of Likitha
> Shetty
> Sent: Friday, February 08, 2013 1:28 AM
> To: Murali Reddy
> Cc: cloudstack; Likitha Shetty
> Subject: Review Request: UpdateNetwork fails with NPE
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9378/
> -----------------------------------------------------------
> 
> Review request for cloudstack and Murali Reddy.
> 
> 
> Description
> -------
> 
> UpdateNetwork API fails with NPE if the network offering is not being updated
> and the network-offering is non-persistent.
> 
> 
> This addresses bug CLOUDSTACK-1207.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java d38d1f8
> 
> Diff: https://reviews.apache.org/r/9378/diff/
> 
> 
> Testing
> -------
> 
> 1. Created a network from a non-persistent NetworkOffering.
> 2. Update the network name - Network Update should return success and the
> network name should be updated.
> 
> 
> Thanks,
> 
> Likitha Shetty

Reply via email to