Ok so if content looks good can one of the committer apply patch to master and close this review
> -----Original Message----- > From: Radhika PC [mailto:nore...@reviews.apache.org] On Behalf Of Radhika > PC > Sent: Thursday, February 07, 2013 12:24 AM > To: Chip Childers; Joe Brockmeier; Vijayendra Bhamidipati; Murali Reddy; > Jessica Tomechak > Cc: Radhika Puthiyetath; cloudstack > Subject: Re: Review Request: Documentation for the new features: Optional > Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services in > the shared network in the advanced zone, and User-provided hostname in > vCenter > > > > > On Feb. 6, 2013, 3:21 a.m., Jessica Tomechak wrote: > > > CLOUDSTACK-265, optional public IP for EIP with basic zone: passed IP > clearance 1/30, but comparing the proposed code at > http://people.apache.org/~muralireddy/ to the current code, I do not see it in > 4.1 or master branches. CLOUDSTACK-312, L4-L7 network services: passed IP > clearance 1/30, but comparing the proposed code at > http://people.apache.org/~muralireddy to the repo, I do not see it in 4.1 or > master branches. CLOUDSTACK-778, user-provided hostname, isn't in 4.1. See > Vijay B's comment in the bug today: "The patch didn't make it to 4.1.0. Moving > to 4.2.0." I have emailed Murali to ask the status of these features. > > > > Radhika PC wrote: > > Once i get the confirmation from Murali, i will resubmit the > > patch > > This patch is applicable only for 4.2 as patch for both bugs 312, 265 did > not go > in to 4.1. Confirmed with Murali. > > > - Radhika > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8180/#review16162 > ----------------------------------------------------------- > > > On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/8180/ > > ----------------------------------------------------------- > > > > (Updated Jan. 15, 2013, 12:34 p.m.) > > > > > > Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra > Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier. > > > > > > Description > > ------- > > > > This review request is for the documentation written for the following > features: > > > > Optional Public IP assignment for EIP with Basic Zone User-provided > > host name in vCenter Enable L4-L7 network services in the shared > > network in the advanced zone > > > > > > Diffs > > ----- > > > > docs/en-US/Installation_Guide.xml 2f60aca > > docs/en-US/about-working-with-vms.xml 47153e2 > > docs/en-US/append-displayname-vms.xml PRE-CREATION > > docs/en-US/creating-network-offerings.xml ab56920 > > docs/en-US/elastic-ip.xml PRE-CREATION > > docs/en-US/network-offerings.xml c1fd79d > > docs/en-US/networks.xml a7b9ea1 > > docs/en-US/set-up-network-for-users.xml 2b40923 > > docs/en-US/using-multiple-guest-networks.xml 9076a81 > > docs/en-US/using-netscaler-load-balancers.xml c2044de > > docs/en-US/virtual-machines.xml 7c74932 > > > > Diff: https://reviews.apache.org/r/8180/diff/ > > > > > > Testing > > ------- > > > > Patch cleanly applies. doc is reviewed by QA > > > > > > Thanks, > > > > Radhika PC > > > >
