----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/#review16518 -----------------------------------------------------------
This patch looks good, but I cannot apply this to latest master, here is the error: Mins-MacBook-Pro:cloud-asf-patch minc$ git am 0001-CLOUDSTACK-357-ISOs-can-be-deleted-while-still-attac.patch Applying: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM error: patch failed: server/src/com/cloud/vm/dao/UserVmDaoImpl.java:61 error: server/src/com/cloud/vm/dao/UserVmDaoImpl.java: patch does not apply Patch failed at 0001 CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM Please address this ASAP, and upload a new diff, I will commit to master. - Min Chen On Feb. 1, 2013, 7:37 a.m., deepti dohare wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7660/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 7:37 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > Currently no warning or confirmation is given or required to delete an iso > which is attached to a virtual machine. > > Fixing this issue using “force” delete option. > If an admin or a user deletes an ISO which is attached to a vm: > 1. Without force option; gives a warning that ISO is attached to vm “Failed > to delete iso. It is currently attached to virtual machine. Please detach it > before deleting”. > 2. With force option: first detach the ISO from all vms and then deletes the > ISO. > > > This addresses bug CLOUDSTACK-357. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/user/iso/DeleteIsoCmd.java > 4c370c7 > server/src/com/cloud/template/TemplateManagerImpl.java 42106b3 > server/src/com/cloud/vm/dao/UserVmDao.java 9fbcde3 > server/src/com/cloud/vm/dao/UserVmDaoImpl.java db1d877 > ui/scripts/templates.js 040ce4a > > Diff: https://reviews.apache.org/r/7660/diff/ > > > Testing > ------- > > Verified locally. Tested for some cases: > > 1. Deleting iso(not attached to any vm) > 2. Deleting iso(attached to multiple vms in same domain) > 3. Deleting iso(attached to multiple vms in different domains) > > For admin/user > > > Thanks, > > deepti dohare > >
