On Tue, Feb 12, 2013 at 02:12:21AM -0500, Animesh Chaturvedi wrote: > Prasanna > > Can you review the updated patch and if it looks good apply it to > master and close the item >
Pushed to reqd branches. Let's use the practice however to enforce that whoever marks ship it ideally commits the patch if they have committer privileges. If you are okay with the patch and want counter-review from another committer it's okay to say LGTM or some such and add the reviewer or have the contributor add them (which is what I asked of Wei in this case). RB or gerrit - the tool only helps when used as per workflows. Just my 2cents -- Prasanna.,