Fixed on master:
commit 9fd09a7f5fe732a888f10c1dfffb9de28e485ae1
Author: Rohit Yadav <bhais...@apache.org>
Date: Wed Feb 13 12:40:30 2013 +0530
console-proxy: Fix broken build system due to console-proxy moves
I tested with devcloud, while everything else worked, console-proxy
did not work for me.
Regards.
On Wed, Feb 13, 2013 at 12:16 PM, Dave Cahill <dcah...@midokura.com> wrote:
> Thanks Rohit, sounds good.
>
> Aside from the build breakage mentioned below (which I'm not sure how to
> fix), I think two license fixes are needed in the base pom.xml. These two
> exclude lines refer to the old folder structure:
>
> 364 <exclude>console-proxy/js/jquery.js</exclude>
> 372 <exclude>dist/console-proxy/js/jquery.js</exclude>
>
> The cloudstack-rat-master (license validation) build was already failing,
> but this is causing an extra failure according to jenkins.
>
> Thanks,
> Dave.
>
> On Wed, Feb 13, 2013 at 3:28 PM, Rohit Yadav <bhais...@apache.org> wrote:
>
>> Yes Dave I confirm the issue, these commits broke the build:
>>
>> commit 4869f0cacfc1319ac725e35ac4ebd1b59da8e5e1
>> Author: Alex Huang <alex.hu...@citrix.com>
>> Date: Tue Feb 12 15:59:02 2013 -0800
>>
>> Moved console-proxy into services
>>
>> commit 2293caa32e4387d7c71c1d4f677e3015856eff0a
>> Author: Alex Huang <alex.hu...@citrix.com>
>> Date: Tue Feb 12 15:58:38 2013 -0800
>>
>> moved console proxy into services directory. no code change
>>
>> I'll try to fix them on my end unless someone beats me to it.
>> Note to developers: please do a clean build if you refactor something
>> and better run cloudstack to confirm that your refactoring actually
>> works.
>>
>> Regards.
>>
>> On Wed, Feb 13, 2013 at 11:05 AM, Dave Cahill <dcah...@midokura.com>
>> wrote:
>> > This appears to have broken the build according to jenkins too:
>> > https://builds.apache.org/job/cloudstack-master-maven/707/
>> >
>> > From jenkins' console output:
>> >
>> > message : Failed to execute goal
>> > org.apache.maven.plugins:maven-antrun-plugin:1.7:run
>> > (generate-resource) on project cloud-client-ui: An Ant BuildException
>> > has occured:
>> /home/jenkins/jenkins-slave/workspace/cloudstack-master-maven/services/console-proxy/server/dist
>> > does not exist.
>> > around Ant part ...<copy
>> >
>> todir="/home/jenkins/jenkins-slave/workspace/cloudstack-master-maven/client/target/generated-webapp/WEB-INF/classes/vms">...
>> > @ 17:130 in
>> /home/jenkins/jenkins-slave/workspace/cloudstack-master-maven/client/target/antrun/build-main.xml
>> > cause : An Ant BuildException has occured:
>> >
>> /home/jenkins/jenkins-slave/workspace/cloudstack-master-maven/services/console-proxy/server/dist
>> > does not exist.
>> > around Ant part ...<copy
>> >
>> todir="/home/jenkins/jenkins-slave/workspace/cloudstack-master-maven/client/target/generated-webapp/WEB-INF/classes/vms">...
>> > @ 17:130 in
>> /home/jenkins/jenkins-slave/workspace/cloudstack-master-maven/client/target/antrun/build-main.xml
>> > Stack trace :
>> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>> > execute goal org.apache.maven.plugins:maven-antrun-plugin:1.7:run
>> > (generate-resource) on project cloud-client-ui: An Ant BuildException
>> > has occured:
>> /home/jenkins/jenkins-slave/workspace/cloudstack-master-maven/services/console-proxy/server/dist
>> > does not exist.
>> > around Ant part ...<copy
>> >
>> todir="/home/jenkins/jenkins-slave/workspace/cloudstack-master-maven/client/target/generated-webapp/WEB-INF/classes/vms">...
>> > @ 17:130 in
>> /home/jenkins/jenkins-slave/workspace/cloudstack-master-maven/client/target/antrun/build-main.xml
>> >
>> >
>> >
>> > On Wed, Feb 13, 2013 at 1:56 PM, Dave Cahill <dcah...@midokura.com>
>> wrote:
>> >
>> >> Hi,
>> >>
>> >> With a fresh checkout of master, I tried:
>> >>
>> >> mvn -P developer,systemvm clean install
>> >>
>> >>
>> >> And got:
>> >>
>> >>
>> >> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-antrun-plugin:1.7:run (generate-resource) on
>> project cloud-client-ui: An Ant BuildException has occured:
>> /root/incubator-cloudstack/services/console-proxy/server/dist does not
>> exist.
>> >>
>> >> [ERROR] around Ant part ...<copy
>> todir="/root/incubator-cloudstack/client/target/generated-webapp/WEB-INF/classes/vms">...
>> @ 17:95 in /root/incubator-cloudstack/client/target/antrun/build-main.xml
>> >>
>> >> [ERROR] -> [Help 1]
>> >>
>> >>
>> >> I can see that the console-proxy folder was moved in a checkin this
>> morning, but I can't see what's wrong with that checkin.
>> >>
>> >>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=4869f0cacfc1319ac725e35ac4ebd1b59da8e5e1
>> >>
>> >>
>> >>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2293caa32e4387d7c71c1d4f677e3015856eff0a
>> >>
>> >>
>> >> Is anyone else seeing the same issue? Proposed fixes?
>> >>
>> >>
>> >> I also noticed while debugging that the CentOS spec file will likely
>> need to change to deal with the move of console-proxy:
>> >>
>> >> [root@devcloud-kvm incubator-cloudstack]# grep -R "console-proxy/dist"
>> *
>> >>
>> >> packaging/centos63/cloud.spec:install -D
>> console-proxy/dist/systemvm.iso
>> ${RPM_BUILD_ROOT}%{_datadir}/%{name}-common/vms/systemvm.iso
>> >>
>> >> packaging/centos63/cloud.spec:install -D
>> console-proxy/dist/systemvm.zip
>> ${RPM_BUILD_ROOT}%{_datadir}/%{name}-common/vms/systemvm.zip
>> >>
>> >>
>> >> Thanks,
>> >>
>> >> Dave.
>> >>
>> >>
>> >>
>>
