----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9251/#review16489 -----------------------------------------------------------
Ship it! Looks fine. Commit hash: c3be0f995d1b3f5ee1355971143234871ad517d9 - Prachi Damle On Feb. 1, 2013, 11:39 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9251/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 11:39 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > For AuthorizeSecurityGroupIngress RevokeSecurityGroupIngress query calls > parse and set the icmp code and type > > > This addresses bug CLOUDSTACK-1135. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f > > Diff: https://reviews.apache.org/r/9251/diff/ > > > Testing > ------- > > 1. Create a security group > 2. Create a rule with conn.authorize_security_group and specify the > ip_protocol as 'icmp' and 'from_port' and 'to_port' as -1 - The rule should > be successfully created > > > Thanks, > > Likitha Shetty > >
