----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9235/#review16481 -----------------------------------------------------------
Ship it! Filter support looks good. Commit hash: a9de95679e61d938540458f05a178858d25809fb - Prachi Damle On Feb. 1, 2013, 6:37 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9235/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 6:37 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > Add message in the response element of EC2DesrcibeAvailibilityZones. Add > support for filter 'message'. > The value of 'message' should be set to the allocation_state of the zone > Code cleanup > > > This addresses bug CLOUDSTACK-1128. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java b2451c6 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2AvailabilityZone.java > PRE-CREATION > > awsapi/src/com/cloud/bridge/service/core/ec2/EC2AvailabilityZonesFilterSet.java > 994b721 > > awsapi/src/com/cloud/bridge/service/core/ec2/EC2DescribeAvailabilityZonesResponse.java > ae0c233 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 17752af > > Diff: https://reviews.apache.org/r/9235/diff/ > > > Testing > ------- > > 1. Run EC2DescribeAvailaibilityZones - response should contain the > allocation_state of each zone (e.g. enabled) > 2. Run EC2DescribeAvailaibilityZones with filter 'message', the zones > corresponding to the allocation_state should be returned > > > Thanks, > > Likitha Shetty > >
