----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9230/#review16440 -----------------------------------------------------------
Likitha, There seems to be a typo trying to replace ~ by %7E. YOu seem to be doing the other way instead. The changes done seem to encode following 3 characters in the input URL: space, * and ~: Please can you update if you tested all 3 inputs? - Prachi Damle On Feb. 1, 2013, 6:10 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9230/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 6:10 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > Convert space characters in the parameters to %20 while forming a query > string after url-encode because java.net.URLEncoder performs > application/x-www-form-urlencoded-type encoding and not percent-encoding. > According to RFC 3986 as required by Amazon, we need to percent-encode. > > > This addresses bug CLOUDSTACK-1125. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f > > Diff: https://reviews.apache.org/r/9230/diff/ > > > Testing > ------- > > Make any EC2 Query API call with a space in the parameter value - the api > call should be successfully executed and throw an error > > > Thanks, > > Likitha Shetty > >
