----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9223/#review16436 -----------------------------------------------------------
Ship it! The bug fix looks fine Commit hash: 05280976e5caa4cc9105223fea96163abb0b6935 - Prachi Damle On Feb. 1, 2013, 5:31 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9223/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 5:31 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > When EC2DesribeKeyPairs is called with filter 'keynames' it ignored the > key-name provided and lists all the key-pairs > > > This addresses bug CLOUDSTACK-1120. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f > > Diff: https://reviews.apache.org/r/9223/diff/ > > > Testing > ------- > > 1. Create multiple key-pairs with ec2_create_key_pair > 2. run ec2_get_all_key_pairs and provide a key_pair_name - result should > include just one key-pair corresponding to the key-pair name > > > Thanks, > > Likitha Shetty > >