----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9213/#review16314 -----------------------------------------------------------
Ship it! Looks good. Committed with Commit hash: 4e4edc9e42f69b10314d0b09629546acc4db333a - Prachi Damle On Feb. 1, 2013, 4:41 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9213/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 4:41 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > Add support for EC2 ApiI's ModifyImageAttribute and ResetImageAttribute. > Attributes supported are Description and LaunchPermission. > > > This addresses bug CLOUDSTACK-1116. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 78e736f > awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java b2451c6 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 17752af > awsapi/src/com/cloud/bridge/service/core/ec2/EC2ImageLaunchPermission.java > PRE-CREATION > awsapi/src/com/cloud/bridge/service/core/ec2/EC2ModifyImageAttribute.java > 16f5ef7 > > Diff: https://reviews.apache.org/r/9213/diff/ > > > Testing > ------- > > Manual testing done > 1. Run DescribeImages - > 2. Run ModifyImageAttribute - provide a new value for description > 3. Run DescribeImages - description value should be the one provided for 2) > > > Thanks, > > Likitha Shetty > >
