> On Jan. 9, 2013, 8:43 a.m., Nitin Mehta wrote: > > You need to take care of migration as well. Any thoughts on that ? > > Saksham Srivastava wrote: > The fix is only for the new volumes which are created from snapshots > which were themselves created from volumes which have a non-null template id. > In case of parent volume carrying a null template id, the subsequent > volumes created from it will be having null template id. > > >
Ok. Agreed that its not an easy problem to solve. Sorry for the delay but can you rebase your changes and send it back ? - Nitin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8900/#review15181 ----------------------------------------------------------- On Jan. 9, 2013, 7:29 a.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8900/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2013, 7:29 a.m.) > > > Review request for cloudstack and Devdeep Singh. > > > Description > ------- > > Volumes created from snapshots misses the source template information.Fixed > the issue with volumes now getting the template id. > > > This addresses bug CLOUDSTACK-924. > > > Diffs > ----- > > server/src/com/cloud/storage/StorageManagerImpl.java 96f299c > > Diff: https://reviews.apache.org/r/8900/diff/ > > > Testing > ------- > > Verified on local setup. from > template1->instance->snapshot1->volume1->snapshot2->template2 > template2 now has source template id. > > > Thanks, > > Saksham Srivastava > >
