----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7891/#review16106 -----------------------------------------------------------
Ship it! Ship It! - Abhinandan Prateek On Feb. 5, 2013, 10:46 a.m., Koushik Das wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7891/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2013, 10:46 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Alex Huang. > > > Description > ------- > > Adding an already added host fails with error but in the process incorrectly > updates the status of the host to 'Alert'. Have put a check to prevent this. > > > Diffs > ----- > > server/src/com/cloud/resource/ResourceManagerImpl.java f4fa13b > > Diff: https://reviews.apache.org/r/7891/diff/ > > > Testing > ------- > > Steps to repro > 1. Created a vmware cluster and added a host, verify that the status shows as > 'Up' > 2. Added the same host again, fails with error > 3. Refresh the host page in MS UI to verify that host status chages to > 'Alert' from 'Up' > > After applying the fix follow the same repro steps and verify that the host > status doesn't change to 'Alert'. > > > Thanks, > > Koushik Das > >
