> On Feb. 1, 2013, 9:50 a.m., Koushik Das wrote: > > There is another config parameter instance.name based on which a fixed > > suffix is appended to the internal name. What happens to this parameter in > > the context of this fix? Also as part of this fix you are allowing to > > suffix the display name to internal name. Sometime back I saw a request in > > the cs-user list to allow account name/id to be appended to the internal > > instance name. Would it be possible to provide a list of well defined > > attributes (for e.g. display name, account etc.) + fixed suffix.
Is it neccessary to add i-<>-<> as a suffix to displayname or internal name? As a user, I totally agree with the requirements which were posted on https://cwiki.apache.org/confluence/display/CLOUDSTACK/Allow+user+provided+hostname%2C+internal+VM+name+on+hypervisor+for+guest+VMs It seems that the result of this patch does not match the requirements. In setup/db/db/schema-40to410.sql, the field should be 'vm.instancename.flag', not 'vm.hostname.flag'. - Wei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9202/#review16001 ----------------------------------------------------------- On Jan. 31, 2013, 7:21 p.m., Venkata Siva Vijayendra Bhamidipati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9202/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2013, 7:21 p.m.) > > > Review request for cloudstack, Kelven Yang and Frank Zhang. > > > Description > ------- > > Patch to allow user to append display name to internal instance name of guest > VMs on cloudstack during guest VM creation. > > > This addresses bug CS-778. > > > Diffs > ----- > > server/src/com/cloud/configuration/Config.java 4ae144e > server/src/com/cloud/vm/UserVmManagerImpl.java ecf1242 > server/src/com/cloud/vm/dao/VMInstanceDao.java 8b0a523 > server/src/com/cloud/vm/dao/VMInstanceDaoImpl.java 85ad5d0 > setup/db/db/schema-40to410.sql ed4946e > > Diff: https://reviews.apache.org/r/9202/diff/ > > > Testing > ------- > > Manual Testing: > Set the global parameter vm.instancename.flag to true, restart mgmt server, > create a guest VM and provide a display Name value when doing so. The vm > created will have its internal name in the form of i-<>-<>-displayname. > Set the global parameter vm.instancename.flag back to false, restart mgmt > server, and create a guest VM providing the display Name. The vm created will > have the internal name in the form of i-<>-<> > If no display name is provided during instance creation, the vm internal name > will be in the form of i-<>-<>. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
