----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9291/#review16081 -----------------------------------------------------------
Ship it! This just made me smile :) Applied on master; commit 9a44ecf77734a2e9c18751c0d0832901f4acd268 Author: Simon Waterhouse <simon.waterho...@citrix.com> Date: Mon Feb 4 18:12:18 2013 +0000 CLOUDSTACK-1148: Change URL from google as 503 returns from that site cause test to erroneously fail. Signed-off-by: Simon Waterhouse <simon.waterho...@citrix.com> Signed-off-by: Rohit Yadav <bhais...@apache.org> Closing ticket as submitted, thanks Simon for your patch. - Rohit Yadav On Feb. 4, 2013, 6:27 p.m., Simon Waterhouse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9291/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2013, 6:27 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > Fix erroneous test failure described in CLOUDSTACK-1148 by changing the URL > used for a simple wget test from http://www.google.com/ to > http://www.apache.org/ > > > This addresses bug CLOUDSTACK-1148. > > > Diffs > ----- > > agent/test/com/cloud/agent/TestAgentShell.java 0e9be0f > > Diff: https://reviews.apache.org/r/9291/diff/ > > > Testing > ------- > > mvn clean install before change was failing on this test as my NATed IP > address appears to have 'relationship issues' with google. > mvn clean install works fine after the change. > > > Thanks, > > Simon Waterhouse > >