Rant: Can reviewers who are committers commit patches sent for reviews when they can spare time to review and give "ship it" on the review? It becomes confusing whether the patch was committed or not.
Regards. On Thu, Jan 31, 2013 at 9:45 AM, Animesh Chaturvedi <[email protected]> wrote: > > >> -----Original Message----- >> From: Sebastien Goasguen [mailto:[email protected]] >> Sent: Thursday, January 31, 2013 12:07 AM >> To: [email protected] >> Subject: Re: ReviewBoard: Drive to clear pending reviews <PLEASE READ> >> >> >> On Jan 31, 2013, at 5:16 AM, Animesh Chaturvedi >> <[email protected]> wrote: >> >> > If folks fail to respond we can close with no activity. No point letting >> > these sit >> around and then having to keep re-evaluating them later. >> >> IMHO we should make our best effort to get an answer from the folks who sent >> patches. They may not be responding because it took us a long time to review. >> >> It seems that closing reviews would send the wrong signal to people who took >> time to submit a patch. >> >> -Sebastien >> > [Animesh>] Ok we can wait for one more week before closing these out. I will > send individual emails to folks we are waiting on >> >> > >> >> -----Original Message----- >> >> From: [email protected] [mailto:[email protected]] On >> >> Behalf Of Rohit Yadav >> >> Sent: Wednesday, January 30, 2013 5:41 PM >> >> To: [email protected] >> >> Subject: Re: ReviewBoard: Drive to clear pending reviews <PLEASE >> >> READ> >> >> >> >> I've reviewed and commited few patches, some of the reviews were >> >> submitted a long time ago or their submitters have failed to reply >> >> for more than a month now, or are invalid in current version/context, >> >> should we ignore or close those with no activity? >> >> >> >> Regards. >> >> >> >> On Wed, Jan 30, 2013 at 2:57 PM, Animesh Chaturvedi >> >> <[email protected]> wrote: >> >>> Folks >> >>> >> >>> Here is a list from review board pending items (44 actually) If >> >>> your name is in the "Who to take Action" column then check "Action >> >>> to be taken" column and respond to your called action >> >>> >> >>> Rev# Who to take Action Action to be taken >> >>> 9158 Harikrishna "Resubmit the patch after addressing >> >>> comments >> >> from Nitin, Koushik, Nitin to commit the patch if comments are addressed" >> >>> 9157 Harikrishna "Resubmit the patch after addressing >> >>> comments >> >> from Nitin, Koushik, Nitin to commit the patch if comments are addressed" >> >>> 9156 Bharat "Respond to comments, resubmit the >> >>> patch. Tests >> >> missing" >> >>> 9152 Rohit "Seems trivial change, review and commit" >> >>> 9133 Chiradeep Review updated patch and commit if >> >>> satisfied >> >>> 9131 "Chiradeep, Hugo" Chiradeep to provide clarificaton on >> Kanzhe's >> >> email and commit if fit >> >>> 9118 "Murali, Wido, Kelven Yang" Respond to review and commit if >> okay >> >> to ship >> >>> 9110 Sanjay Respond to chiradeep's review comments >> >>> and >> >> resubmit the patch >> >>> 9097 David Nalley Review updated patch and commit if >> >>> satisfied >> >>> 9041 "David Nalley, Min" Review comment response and commit if >> >> satisfied >> >>> 9010 Jayapal Resolve merge conflict and resubmit the >> >>> patch. >> Abhi >> >> to commit >> >>> 8991 "Chip, Jessica" Reference to CloudPlatform is removed. >> >> Chip/Jessica to review and commit >> >>> 8971 Weizhou Update diff and post for review again. Kishan to >> review >> >> and commit >> >>> 8905 Rohit IP clearance should be approved by >> >>> Wednesday >> >> noon. Commit the patch if satisfied on Wednesday >> >>> 8900 Nitin. Devedeep "Review response to review comments, If satisfied >> >> commit the patch" >> >>> 8876 Likitha "Respond to review comments, and submit >> >>> the >> patch >> >> again" >> >>> 8859 Kishan Commit the patch if satisfied >> >>> 8813 Jessica IP clearance should be approved by >> >>> Wednesday. >> >> Commit the patch if satisfied on Wednesday >> >>> 8742 Prachi Commit the patch if satisfied >> >>> 8701 Roeland Kuipers Respond to commit and resubmit the patch after >> >> fixes >> >>> 8632 Prasanna Respond to reviewer comments and submit >> >>> the >> >> patch again >> >>> 8623 Devdeep Respond to reviewer comments and submit the patch >> >> again >> >>> 8613 Prasanna Respond to reviewer comments and submit >> >>> the >> >> patch again >> >>> 8547 Rohit Review patch and commit if satisified >> >>> 8545 Meghna Respond to comment and resubmit the patch. Patch >> >> does not apply cleanly >> >>> 8513 Prachi Review patch and commit if satisified >> >>> 8492 Prachi Review patch and commit if satisified >> >>> 8483 Prachi Review patch and commit if satisified >> >>> 8480 Prachi Review patch and commit if satisified >> >>> 8468 Prachi Review patch and commit if satisified >> >>> 8466 Prachi Review patch and commit if satisified >> >>> 8465 Prachi Review patch and commit if satisified >> >>> 8355 Meghna Respond to comment >> >>> 8307 Kelecey Respond to comment and resubmit the patch >> >>> 8294 Kawai update the patch to the latest state of >> >>> master >> >>> 8293 Hiroaki Respond to reviewer comment >> >>> 8180 Jessica Some items are under ipclearance and as >> >>> soon as >> >> David formally clears IP clearance the patch can be committed >> >>> 7891 Abhinadan Review patch and commit if satisified >> >>> 7827 "Murali, Kelven" Review patch and commit if satisified >> >>> 7802 Joe Review patch and commit if satisified >> >>> 7660 Deepti Patch is old and some of the referenced >> >>> files are >> no >> >> longer there. Review and resubmit >> >>> 7594 Anthony Review updated patch >> >>> 7018 Nitin Review patch and commit if satisified >> >>> 5655 Hugo Check if review still applicable? If not >> >>> close it or >> apply >> >> a fix. >> >>> >> >>> Since tomorrow is our freeze date , it is important to clear out as >> >>> much as humanly possible :) >> >>> >> >>> Animesh >> >>> >
