----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8492/#review15967 -----------------------------------------------------------
Ship it! Looks good to me. Should be covered in the unit tests. - Prachi Damle On Dec. 12, 2012, 10:35 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8492/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 10:35 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > As a part of EC2 Query API support, resolve the NPE obtained when > DescribeAddresses is called > In EC2Engine modify DescribeAddresses implementation to be consistent with > the other Describe* API implementation > > > This addresses bug CLOUDSTACK-611. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/core/ec2/EC2AddressFilterSet.java > cb21fb2 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java eb25249 > > Diff: https://reviews.apache.org/r/8492/diff/ > > > Testing > ------- > > After setting up AWSAPI, using the boto client called > 1. get_all_addresses() > 2. get_all_addresses(addresses='<cs_address>') > Both successfully returned the existing public-ip's. > > > Thanks, > > Likitha Shetty > >
