----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8468/#review15963 -----------------------------------------------------------
Ship it! Fix is correct. - Prachi Damle On Dec. 12, 2012, 10:38 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8468/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 10:38 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > Before making the AuthorizeSecurityGroupIngress CloudStack API call, parse > the string arguments 'FromPort' and 'ToPort' as an integer. > > > This addresses bug CLOUDSTACK-613. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 4f74873 > > Diff: https://reviews.apache.org/r/8468/diff/ > > > Testing > ------- > > After setting up AWSAPI, using the boto client called > authorize_security_group(group_name=<sg_name>, ip_protocol=<protocol>, > from_port=<from_port>, to_port=<to_port>, cidr_ip=<cidr>) > Successfully created the specified rule in the security-group. > > > Thanks, > > Likitha Shetty > >
