-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8613/#review15752
-----------------------------------------------------------
I tried to apply your snapshot patches and test them, as they look reasonable,
unfortunately I think something else is broken at the moment because snapshot
cleanup is still not working. This patch may be useful but it's hard to tell
with snapshot deletes still broken. We'll have to open a bug for it if there's
not one already.
at com.cloud.agent.api.SnapshotCommand.<init>(SnapshotCommand.java:56)
at
com.cloud.agent.api.DeleteSnapshotBackupCommand.<init>(DeleteSnapshotBackupCommand.java:89)
at
com.cloud.storage.snapshot.SnapshotManagerImpl.destroySnapshotBackUp(SnapshotManagerImpl.java:916)
at
com.cloud.utils.db.DatabaseCallback.intercept(DatabaseCallback.java:34)
at
com.cloud.storage.snapshot.SnapshotManagerImpl.deleteSnapshotInternal(SnapshotManagerImpl.java:847)
at
com.cloud.storage.snapshot.SnapshotManagerImpl.deleteSnapshot(SnapshotManagerImpl.java:794)
at
com.cloud.utils.component.ComponentLocator$InterceptorDispatcher.intercept(ComponentLocator.java:1262)
at
org.apache.cloudstack.api.command.user.snapshot.DeleteSnapshotCmd.execute(DeleteSnapshotCmd.java:92)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:168)
at
com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:435)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:722)
This is against current master. I think the first big issue to tackle is to
make it stop returning success when it obviously fails.
- Marcus Sorensen
On Dec. 18, 2012, 12:06 a.m., Prasanna Santhanam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8613/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2012, 12:06 a.m.)
>
>
> Review request for cloudstack, edison su and Marcus Sorensen.
>
>
> Description
> -------
>
> KVM snapshot command objects return absolute path to their qcow2
> backups while the SSVM responsible for the snapshot deletion builds a
> path from the tenant's associated path. This causes a quiet failure
> resulting in a successful answer back to management server while the
> image still persists on sec. storage.
>
> Cmd object sent by management server:
>
> {
> Cmd,
> MgmtId: 345050870294,
> via: 11,
> Ver: v1,
> Flags: 100011,
> [
> {
> "DeleteSnapshotBackupCommand": {
> "all": false,
> "snapshotUuid":
> "/snapshots/3/7/31/any_ROOT-29_20121214210220",
> "secondaryStorageUrl":
> "nfs://secstorage/export/home/storage/secondary",
> "dcId": 3,
> "accountId": 7,
> "volumeId": 31,
> "wait": 0
> }
> }
> ]
> }
>
> Path interpreted by CS:
> secondaryStorageUrl + dcId + accountId + volumeId + snapshotUuid
> =
> nfs://secstorage/export/home/storage/secondary/3/7/31/snapshots/3/7/31/any_ROOT-29_20121214210220
>
> While it should be
> =
> nfs://secstorage/export/home/storage/secondary/snapshots/3/7/31/any_ROOT-29_20121214210220
>
>
> This addresses bug cloudstack-643.
>
>
> Diffs
> -----
>
> core/pom.xml 3d6356e
> core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java
> d8fdc3a
>
> Diff: https://reviews.apache.org/r/8613/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasanna Santhanam
>
>
