----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9110/#review15746 -----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceCountCmd.java <https://reviews.apache.org/r/9110/#comment33898> whts the unit for ram and cpu ? Also lets call it memory instead of ram because thats how we have been using it api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLimitCmd.java <https://reviews.apache.org/r/9110/#comment33902> Values are ...... should be changed accordingly api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLimitCmd.java <https://reviews.apache.org/r/9110/#comment33899> is it cpu speed ? cores ? server/src/com/cloud/configuration/Config.java <https://reviews.apache.org/r/9110/#comment33900> you missed the migration code server/src/com/cloud/configuration/Config.java <https://reviews.apache.org/r/9110/#comment33901> lets name it memory server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/9110/#comment33903> I see this boilerplate code everywhere. Please make this a single line function call - Nitin Mehta On Jan. 25, 2013, 1:52 p.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9110/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2013, 1:52 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > CLOUDSTACK-713: Limit Resources to domain/accountsi(CPU and RAM) > > Addition of two new resource types i.e. CPU and RAM in the existing pool > of > resource types. > Added some methods to set the limits on these resources using > updateResource > API command and to get a count using updateResourceCount. Also added > calls in > Virtual machine life cycle to check these limits and to > increment/decrement > resource count > > Resource Name :: Resource type number > CPU 8 > RAM 9 > > > This addresses bug CLOUDSTACK-713. > > > Diffs > ----- > > api/src/com/cloud/configuration/Resource.java 7f551d6 > > api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceCountCmd.java > 4aa694b > > api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLimitCmd.java > 9b6359f > api/src/org/apache/cloudstack/api/response/ResourceCountResponse.java > 7a29194 > api/src/org/apache/cloudstack/api/response/ResourceLimitResponse.java > c01e12f > server/src/com/cloud/baremetal/BareMetalVmManagerImpl.java 57cfb39 > server/src/com/cloud/configuration/Config.java 4ae144e > server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java c17b0ea > server/src/com/cloud/vm/UserVmManagerImpl.java 5891056 > server/test/com/cloud/resourcelimit/ResourceLimitManagerImplTest.java > PRE-CREATION > server/test/com/cloud/vpc/MockResourceLimitManagerImpl.java a0c7b70 > > Diff: https://reviews.apache.org/r/9110/diff/ > > > Testing > ------- > > Manually tested on my local CloudStack setup. Also added unit tests file in > the patch. > > > Thanks, > > Sanjay Tripathi > >
