----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8465/#review15599 -----------------------------------------------------------
Code fix looks fine. Unit-tests should cover this. - Prachi Damle On Dec. 12, 2012, 10:29 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8465/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 10:29 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > As a part of EC2 Query API support, resolve the NPE obtained when > DescribeKeyPairs is called > In EC2Engine modify DescribeKeyPairs implementation to be consistent with the > other Describe* API implementation > > > This addresses bug CLOUDSTACK-608. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java eb25249 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2KeyPairFilterSet.java > 021487c > > Diff: https://reviews.apache.org/r/8465/diff/ > > > Testing > ------- > > After setting up AWSAPI, using the boto client called > 1. get_all_key_pairs() > 2. get_all_key_pairs(keynames='<cs_key_name>') > Both successfully returned the existing key-pairs. > > > Thanks, > > Likitha Shetty > >
