----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8937/#review15300 -----------------------------------------------------------
Ship it! LGTM - Prasanna Santhanam On Jan. 12, 2013, 7:16 p.m., Noa Resare wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8937/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2013, 7:16 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > Introduce UnknownSystemExcpetion to indicate that the system is > is unknonwn. Catch said exception in cloud-setup-management, > print an error and exit. > > CLOUDSTACK-966: Improve error reporting when running on unknown OS / > version > > > This addresses bug CLOUDSTACK-966. > > > Diffs > ----- > > client/bindir/cloud-setup-management.in 469c961 > python/lib/cloudutils/utilities.py adf81fc > > Diff: https://reviews.apache.org/r/8937/diff/ > > > Testing > ------- > > > Thanks, > > Noa Resare > >
