Yes, I did a commit yesterday to completely get rid of IdentityProxy and IdentityTypeAdapter class to keep new developers from wrongly using them again in newly introduced Response class.
Thanks -min On 1/10/13 2:31 AM, "Prasanna Santhanam" <t...@apache.org> wrote: >On Thu, Jan 10, 2013 at 03:57:49PM +0530, Prasanna Santhanam wrote: >> On Wed, Jan 09, 2013 at 05:45:03PM -0500, Min Chen wrote: >> > Hi Marcus, >> > >> > To answer your question below: >> > "Does this mean we won't see 10 "SELECT uuid FROM `vm_instance` >> > WHERE id=3079 OR uuid='3079'" type calls for every VM we have when >> > doing listVirtualMachines and such?" >> > Yes, that is exactly one item we have fixed in api_refactoring in >> > removing all IdentityProxy fields from all Response class, which >> > will not invoke such select during JSON serialization phase for each >> > VM. >> > >> >> Min, speaking about the IdentityProxy it appears that all the >> BaseAsyncCreateCmds right now refer back to the IdentityProxy via the >> getEntityTable() method. This table is referred back in the >> ApiResponseSerializer to execute the 'select id or uuid' stmt when >> building response type in XML. JSON doesn't refer to this however. Can >> we remove the IdentityProxy in these cases too? >> >> Also the method getEntityTable() also should probably go away to >> remove any traces of direct references back to the underlying db >> entity? > >D'oh - didn't see that you removed this already. Just got the latest: > >commit 7f8262d45e9f2cdaa5d8f1aee0df61dab9573dd7 >Author: Min Chen <min.c...@citrix.com> >Date: Wed Jan 9 17:40:58 2013 -0800 > > Remove IdentityProxy and IdentityTypeAdapter class. > > >Thanks, > >-- >Prasanna.,
