----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8546/#review15176 -----------------------------------------------------------
This change looks good to me, however, due to recent api_refactoring merge into master branch, I cannot apply this patch on master due to package name change, here is the error: unknown14109fdb491b:cloud-asf minc$ git am < patchdir/0001-CLOUDSTACK-614-ListTemplates-API-is-not-returning-En.patch Applying: CLOUDSTACK-614: ListTemplates API is not returning "Enable SSH Key" attribute for any given template. error: api/src/com/cloud/api/response/TemplateResponse.java: does not exist in index Patch failed at 0001 CLOUDSTACK-614: ListTemplates API is not returning "Enable SSH Key" attribute for any given template. Can you please create another patch based on latest master code and then I can apply it for you? Thanks. - Min Chen On Jan. 9, 2013, 4:22 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8546/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2013, 4:22 a.m.) > > > Review request for cloudstack, Alena Prokharchyk and Min Chen. > > > Description > ------- > > Update the TemplateResponse by adding 'sshkeyenabled' attribute to it. This > attribute is set to the value that the user passes as input for parameter > 'sshkeyenabled' while registering the template. > > > This addresses bug CLOUDSTACK-614. > > > Diffs > ----- > > api/src/com/cloud/api/response/TemplateResponse.java 5c3d339 > server/src/com/cloud/api/ApiResponseHelper.java ebe8415 > > Diff: https://reviews.apache.org/r/8546/diff/ > > > Testing > ------- > > Called API command=listTemplates&listall=true&templatefilter=featured > The JSON response contained a boolean SSH related attribute called > 'sshkeyenabled' which mentioned if the template is SSH enabled or not. > > > Thanks, > > Likitha Shetty > >
