----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8855/ -----------------------------------------------------------
(Updated Jan. 8, 2013, 8:06 a.m.) Review request for cloudstack, Abhinandan Prateek and Alex Huang. Changes ------- Made changes to handle the case if config value is not present in db. Description ------- Currently the DirectAgent pool size is hard-coded to 500. One of the factors that can affect this is the number of hosts in a deployment. If there are more than 500 hosts (say around 1K) then this pool can easily get exhausted resulting in delays and undesired behavior. Removed hard-coding of directagent thread pool size and now reading it from configuration. This addresses bug CLOUDSTACK-810. Diffs (updated) ----- server/src/com/cloud/agent/manager/DirectAgentAttache.java 848c7e6 server/src/com/cloud/configuration/Config.java 92313ea setup/db/db/schema-40to410.sql 4455956 Diff: https://reviews.apache.org/r/8855/diff/ Testing ------- Verified that configuration entry is present in the 'configuration' table. Also verified in a debugger that it is read correctly while creating the directagent thread pool. Thanks, Koushik Das
