----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8857/#review15110 -----------------------------------------------------------
Ship it! Looks good to me. Verified the change on my set up as well . I'll push the change to asf/master. Thanks ! - Pranav Saxena On Jan. 7, 2013, 12:47 p.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8857/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2013, 12:47 p.m.) > > > Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang. > > > Description > ------- > > We are logging passwords for createAccount/User API in the access logs. > Though they are md5 hashed but the same can be easily used for logging in. > UI should make a POST call for them instead of a GET. > > > This addresses bug CLOUDSTACK-819. > > > Diffs > ----- > > ui/scripts/accounts.js de8149f > > Diff: https://reviews.apache.org/r/8857/diff/ > > > Testing > ------- > > Verified on my local CloudStack setup. > > > Thanks, > > Sanjay Tripathi > >
