> On Dec. 13, 2012, 3:11 p.m., Joe Brockmeier wrote:
> > A couple of notes:
> > 
> > We should distinguish between DevCloud tools / scripts that are shipped 
> > with CloudStack source, and DevCloud that's provided as a pre-made OVA by 
> > community members. The DevCloud appliance is not an official Apache release 
> > and - indeed - is not something Apache can ship. 
> > 
> > Please be sure that titles are consistent in capitalization with the rest 
> > of the guides, etc.  Product names (like Puppet, Vagrant) should also be 
> > capitalized (excepting, I guess veewee, which is not capped). 
> > 
> > Do we want to be pointing to specific wiki pages in the docs? I'm going to 
> > raise this as a separate DISCUSS, because I'm unsure - but pointing to the 
> > wiki for docs seems a little iffy since that content will change more 
> > rapidly than the ACS Publican docs. (Note that I'm only referring to 
> > pointing to a specific page for instructions - I think saying something 
> > like "check the wiki for a WIP document" makes sense.) 
> > 
> > Another item - the new docs only cover Ubuntu. Is that in keeping with the 
> > rest of the docs? We document procedures for CentOS/RHEL and Ubuntu 
> > throughout - shouldn't we do the same for developers? 
> > 
> > Line 37: docs/en-US/building-with-maven-deploy.xml - grammar error 
> > (loose/lose) and I don't think data center needs caps here.
> > 
> > Line 31: docs/en-US/building-with-maven-steps.xml needs a period at the end 
> > of the sentence.
> > 
> > Thanks!
> > 
> > Joe
> 
> Sebastien Goasguen wrote:
>     Thanks Joe.
>     I will check the caps issue, grammar and such. (but honestly, it would be 
> nice to get the checkin done and then I can correct the committed version).
>     
>     I will also check that it is clearly spelled out that the ova is not a 
> Apache release product.
>     
>     With regards to the wiki, I put some notes on there. The thought was to 
> have some minimal documentation and some links that refer to more up-to-date 
> docs on the wiki.
>     
>     I only put Ubuntu on there to get started and have the framework. Someone 
> building it on CentOS/RHEL could then add it.

Looks like this was applied to master with 
6507055ba1df63ef280200fda9e9f33563e3243e
Can I close it ?


- Sebastien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8553/#review14437
-----------------------------------------------------------


On Dec. 15, 2012, 10:35 p.m., Sebastien Goasguen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8553/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2012, 10:35 p.m.)
> 
> 
> Review request for cloudstack, Chip Childers and Joe Brockmeier.
> 
> 
> Description
> -------
> 
> Removes "API" from dev guide title to make it more generic.
> Adds chapter on Maven build (CS-1)
> Adds chapter on tools with sections on devcloud and marvin
> 
> 
> This addresses bug CS-1.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/API_Developers_Guide.ent 47a2b67 
>   docs/en-US/API_Developers_Guide.xml c691ad0 
>   docs/en-US/Developers_Guide.ent PRE-CREATION 
>   docs/en-US/Developers_Guide.xml PRE-CREATION 
>   docs/en-US/building-devcloud.xml PRE-CREATION 
>   docs/en-US/building-prerequisites.xml PRE-CREATION 
>   docs/en-US/building-with-maven-deploy.xml PRE-CREATION 
>   docs/en-US/building-with-maven-steps.xml PRE-CREATION 
>   docs/en-US/building-with-maven.xml PRE-CREATION 
>   docs/en-US/devcloud-usage-mode.xml PRE-CREATION 
>   docs/en-US/devcloud.xml PRE-CREATION 
>   docs/en-US/developer-introduction.xml bb5251b 
>   docs/en-US/images/DevCloud-hostonly.png PRE-CREATION 
>   docs/en-US/images/DevCloud.png PRE-CREATION 
>   docs/en-US/marvin.xml PRE-CREATION 
>   docs/en-US/source-build.xml PRE-CREATION 
>   docs/en-US/tools.xml PRE-CREATION 
>   docs/publican-devguide.cfg 006c0d1 
> 
> Diff: https://reviews.apache.org/r/8553/diff/
> 
> 
> Testing
> -------
> 
> built publican book, looked at the pdf
> 
> 
> Thanks,
> 
> Sebastien Goasguen
> 
>

Reply via email to